Skip to content

Commit

Permalink
fix: use cli specific description for --open-app-name and `--web-so…
Browse files Browse the repository at this point in the history
…cket-server`
  • Loading branch information
snitin315 committed Jan 22, 2022
1 parent b8ddf9f commit 82eda54
Show file tree
Hide file tree
Showing 6 changed files with 163 additions and 237 deletions.
9 changes: 7 additions & 2 deletions lib/options.json
Expand Up @@ -581,7 +581,10 @@
{
"type": "string",
"minLength": 1,
"description": "Open specified browser. Deprecated: please use '--open-app-name'."
"description": "Open specified browser.",
"cli": {
"description": "Open specified browser. Deprecated: please use '--open-app-name'."
}
}
],
"description": "Open specified browser."
Expand Down Expand Up @@ -1043,7 +1046,9 @@
"$ref": "#/definitions/WebSocketServerType"
}
],
"description": "Deprecated: please use '--web-socket-server-type' option."
"cli": {
"description": "Deprecated: please use '--web-socket-server-type' option."
}
},
"WebSocketServerFunction": {
"instanceof": "Function"
Expand Down
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -113,7 +113,7 @@
"tcp-port-used": "^1.0.2",
"typescript": "^4.2.4",
"url-loader": "^4.1.1",
"webpack": "^5.64.0",
"webpack": "^5.67.0",
"webpack-cli": "^4.7.2",
"webpack-merge": "^5.8.0"
},
Expand Down
4 changes: 1 addition & 3 deletions test/__snapshots__/validate-options.test.js.snap.webpack4
Expand Up @@ -521,7 +521,7 @@ exports[`options validate should throw an error on the "open" option with '{"app
* options.open.app should be an object:
object { name?, arguments? }
* options.open.app should be a non-empty string.
-> Open specified browser. Deprecated: please use '--open-app-name'."
-> Open specified browser."
`;

exports[`options validate should throw an error on the "open" option with '{"foo":"bar"}' value 1`] = `
Expand Down Expand Up @@ -929,7 +929,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
Details:
* options.webSocketServer should be one of these:
false | \\"sockjs\\" | \\"ws\\"
-> Deprecated: please use '--web-socket-server-type' option.
Details:
* options.webSocketServer should be false.
* options.webSocketServer should be one of these:
Expand All @@ -949,7 +948,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
Details:
* options.webSocketServer should be one of these:
false | \\"sockjs\\" | \\"ws\\"
-> Deprecated: please use '--web-socket-server-type' option.
Details:
* options.webSocketServer should be false.
* options.webSocketServer should be one of these:
Expand Down
4 changes: 1 addition & 3 deletions test/__snapshots__/validate-options.test.js.snap.webpack5
Expand Up @@ -521,7 +521,7 @@ exports[`options validate should throw an error on the "open" option with '{"app
* options.open.app should be an object:
object { name?, arguments? }
* options.open.app should be a non-empty string.
-> Open specified browser. Deprecated: please use '--open-app-name'."
-> Open specified browser."
`;

exports[`options validate should throw an error on the "open" option with '{"foo":"bar"}' value 1`] = `
Expand Down Expand Up @@ -929,7 +929,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
Details:
* options.webSocketServer should be one of these:
false | \\"sockjs\\" | \\"ws\\"
-> Deprecated: please use '--web-socket-server-type' option.
Details:
* options.webSocketServer should be false.
* options.webSocketServer should be one of these:
Expand All @@ -949,7 +948,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
Details:
* options.webSocketServer should be one of these:
false | \\"sockjs\\" | \\"ws\\"
-> Deprecated: please use '--web-socket-server-type' option.
Details:
* options.webSocketServer should be false.
* options.webSocketServer should be one of these:
Expand Down

0 comments on commit 82eda54

Please sign in to comment.