Skip to content

Commit

Permalink
fixes #1086: promise configs fix and example
Browse files Browse the repository at this point in the history
  • Loading branch information
shellscape committed Sep 14, 2017
1 parent 35295b7 commit 8f897c5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bin/webpack-dev-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -344,15 +344,15 @@ function processOptions(webpackOptions) {
options.port = argv.port === DEFAULT_PORT ? defaultTo(options.port, argv.port) : defaultTo(argv.port, options.port);

if (options.port != null) {
startDevServer(wpOpt, options);
startDevServer(webpackOptions, options);
return;
}

portfinder.basePort = DEFAULT_PORT;
portfinder.getPort((err, port) => {
if (err) throw err;
options.port = port;
startDevServer(wpOpt, options);
startDevServer(webpackOptions, options);
});
}

Expand Down

3 comments on commit 8f897c5

@richtera
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this or will this be in the npm registry?

@shellscape
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. we're looking into one more issue before publishing. you can always count on critical fixes like this being published in a timely manner. if you're in immediate need, you can downgrade to 2.7.1 or reference the git repo as an npm dep directly.

@richtera
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use my fork until then. I'll monitor this.

Please sign in to comment.