fixes #1081, closes #1079. addDevServerEndpoints needs app stub for

createDomain
webpack · Sep 13, 2017 · e5dc236 · e5dc236
1 parent e61972a
commit e5dc236
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/util/addDevServerEntrypoints.js b/lib/util/addDevServerEntrypoints.js
@@ -4,9 +4,17 @@
 
 const createDomain = require('./createDomain');
 
-module.exports = function addDevServerEntrypoints(webpackOptions, devServerOptions) {
+module.exports = function addDevServerEntrypoints(webpackOptions, devServerOptions, listeningApp) {
   if (devServerOptions.inline !== false) {
-    const domain = createDomain(devServerOptions);
+    // we're stubbing the app in this method as it's static and doesn't require
+    // a listeningApp to be supplied. createDomain requires an app with the
+    // address() signature.
+    const app = listeningApp || {
+      address() {
+        return { port: devServerOptions.port };
+      }
+    };
+    const domain = createDomain(devServerOptions, app);
     const devClient = [`${require.resolve('../../client/')}?${domain}`];
 
     if (devServerOptions.hotOnly) { devClient.push('webpack/hot/only-dev-server'); } else if (devServerOptions.hot) { devClient.push('webpack/hot/dev-server'); }