Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output startup info if quiet is set to true #970

Merged
merged 6 commits into from Jul 10, 2017

Conversation

larsbs
Copy link
Contributor

@larsbs larsbs commented Jul 4, 2017

What kind of change does this PR introduce?
Use quiet option to decide if webpack should print startup info or not.

Did you add or update the examples/?
No

Summary
As stated by @jonathanconway in webpack/webpack#1191 there's no way to fully disable all logs. Also, I've been investigating and didn't find where the noInfo option is used so I decided to use it to disable the startup info.

Does this PR introduce a breaking change?
No

Other information

@jsf-clabot
Copy link

jsf-clabot commented Jul 4, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 7, 2017

Codecov Report

Merging #970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           4        4           
  Lines         463      463           
  Branches      139      139           
=======================================
  Hits          334      334           
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9188878...497fe39. Read the comment docs.

Copy link
Contributor

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've already got the quiet option, and it's apparently supposed to do what you're attempting to do with noInfo see:

I'd say use that option here instead.

@larsbs
Copy link
Contributor Author

larsbs commented Jul 10, 2017

@shellscape but then the noInfo option is useless again. At least when I've searched for it in the code is used nowhere. For me it's ok, I can change the code to use quiet, but why keep an unused option around?

@shellscape
Copy link
Contributor

It might be there for legacy reasons, not entirely sure.

@shellscape shellscape changed the title Don't output startup info if noInfo is set to true Don't output startup info if quiet is set to true Jul 10, 2017
@shellscape shellscape merged commit 140da45 into webpack:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants