Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully mute output info if quiet is set to true #999

Merged
merged 3 commits into from
Jul 27, 2017
Merged

Fully mute output info if quiet is set to true #999

merged 3 commits into from
Jul 27, 2017

Conversation

stephenlacy
Copy link
Contributor

This fully mutes all startup messages if quiet is set.

What kind of change does this PR introduce?
This follows #970 and fully mutes all startup messages if quiet is set instead of just half.

Did you add or update the examples/?
No

Summary
Fully mutes all messages following webpack/webpack#1191 and #970.
This fixes issues on our build runners where stdout was outputted from the build even with quiet set.

Does this PR introduce a breaking change?
No

Other information

This fully mutes all startup messages if quiet is set.
@jsf-clabot
Copy link

jsf-clabot commented Jul 20, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 20, 2017

Codecov Report

Merging #999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           4        4           
  Lines         463      463           
  Branches      139      139           
=======================================
  Hits          334      334           
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8207238...07e802f. Read the comment docs.

@shellscape shellscape merged commit 628f0a2 into webpack:master Jul 27, 2017
@stephenlacy stephenlacy deleted the quiet branch July 27, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants