Add subjectAltName to self-signed certificate for https #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes webpack#854 and webpack#906 by adding a subjectAltName matching the commonName for the self-signed cert.
|
|
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 4 4
Lines 465 465
Branches 139 139
=======================================
Hits 336 336
Misses 129 129
Continue to review full report at Codecov.
|
|
Really appreciate taking the time to open a PR ❤️ Unfortunately this is a duplicate of #987. Please check out the comments on that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #854 and #906 by adding a subjectAltName matching
the commonName for the self-signed cert.
I've been using
webpack-dev-serverwith Rails 5 and it's been quite frustrating to have to manually click "proceed" when using Chrome, even after trusting the self-signed cert.This PR adds the requisite subjectAltName to the self-signed cert so that Chrome no longer displays the error message described at #854 and #906
What kind of change does this PR introduce?
Simply adds a config option to the self-signed cert.
Did you add or update the
examples/?No, but tested using the https example.
Summary
Using webpack-dev-server for Rails 5 development and repeatedly having to visit the server manually in Chrome before I can continue development.
Does this PR introduce a breaking change?
No.
Other information
This PR shouldn't have any side-effects, other than fixing https in Chrome.