Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the port from the options object #1079

Closed
wants to merge 2 commits into from
Closed

Get the port from the options object #1079

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
656a494
Get the port from the options object
binhqx Sep 13, 2017
724b40f
Merge branch 'master' into patch-1
binhqx Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/util/createDomain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const internalIp = require('internal-ip');

module.exports = function createDomain(options, listeningApp) {
const protocol = options.https ? 'https' : 'http';
const appPort = listeningApp ? listeningApp.address().port : 0;
const appPort = listeningApp ? listeningApp.address().port : options.port.toString();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break dynamic port assignment, port 0 was intentional there for that reason.

const port = options.socket ? 0 : appPort;
const hostname = options.useLocalIp ? internalIp.v4() : options.host;

Expand Down