Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow explicitly setting the protocol from the public option #1117

Merged
merged 11 commits into from
Oct 8, 2017
Merged

allow explicitly setting the protocol from the public option #1117

merged 11 commits into from
Oct 8, 2017

Commits on Sep 26, 2017

  1. allow explicitly setting the protocol from the public option

    @robertaistleitner
    robertaistleitner committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    eecad00 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2017

  1. add feedback from PR + add example 

     + found one other glitch that auto-reload doesn't work in iframes since it tries to reload the iframe itself (which has src `about:blank`) and therefore cannot be reloaded properly. I'm now checking for protocol `about:` and traverse upwards until a reloadable window can be found. Feedback on this fix is welcome!
    @robertaistleitner
    robertaistleitner committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    3b204ee View commit details
    Browse the repository at this point in the history

  2. fix linting issues

    @robertaistleitner
    robertaistleitner committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    972825e View commit details
    Browse the repository at this point in the history

  3. provide tests for createDomain helper function 

     + found a bug due to tests: `url.parse` doesn't properly parse a provided `public` option since it counts everything before the port colon as the protocol which is just wrong. I replaced it with a protocol regex.
    @robertaistleitner
    robertaistleitner committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    650182f View commit details
    Browse the repository at this point in the history

  4. increase timeout for https test which exceeds default 2000ms

    @robertaistleitner
    robertaistleitner committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    21c54c6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into master

    @shellscape
    shellscape committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    b1a4eb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Merge branch 'master' into master

    @robertaistleitner
    robertaistleitner committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    ef0e57b View commit details
    Browse the repository at this point in the history

  2. move info log to the place where the reload happens

    @robertaistleitner
    robertaistleitner committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    9e6b272 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2017

  1. apply feedback 

     * remove docker stuff from examples (minimize example)
 * use setInterval and clearInterval instead of do while loop when getting root window for reload
    @robertaistleitner
    robertaistleitner committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    cfdb070 View commit details
    Browse the repository at this point in the history

  2. increase test timeout for https to 60 seconds

    @robertaistleitner
    robertaistleitner committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    f481d0f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Merge branch 'master' into master

    @shellscape
    shellscape committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    e170f18 View commit details
    Browse the repository at this point in the history