Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built version os sockjs-client #1148

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Commits on Oct 16, 2017

  1. Use built version os sockjs-client

    `webpack-dev-server` bundles `sockjs-client` from source. `sockjs-client` sources assume a node environment however, and will fail to run if `global` is not available.
    
    By bundling `sockjs-client` from source, the node environment requirement from `sockjs-client` will also be required of the app being served and thus it is not possible to have `node.global = false` in the user app being bundled.
    
    This fix uses the built `sockjs-client` instead of the sources.
    
    Fix webpack#1147
    filipesilva committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    fe5e48c View commit details
    Browse the repository at this point in the history