Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate stats configuration (webpack 3.8.0+ compatibility) #1174

Merged

Commits on Nov 3, 2017

  1. don't mutate stats configuration

    The webpack configuration `stats` property has the same format as the
    `devServer.stats` property, so the same object is frequently reused to
    define the same stats output.
    
    Since webpack v3.8.0, the `stats` property is validated more strictly by
    webpack.  webpack-dev-server is mutating this `stats` object by adding a
    `colors` property, which is an object and doesn't match the webpack
    configuration schema, causing a fatal error.
    
    The easy fix is to *not* mutate the `stats` object, so webpack isn't
    breaking with a fatal error.  But we may also consider setting a valid
    `colors` property.
    BenoitZugmeyer committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    06ebc25 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2017

  1. Configuration menu
    Copy the full SHA
    5e2ff6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b2a76a View commit details
    Browse the repository at this point in the history