Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable page reload when hot is not specified #1275

Closed
wants to merge 1 commit into from
Closed

Fix: disable page reload when hot is not specified #1275

wants to merge 1 commit into from

Conversation

byzyk
Copy link
Member

@byzyk byzyk commented Jan 15, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Aimed to fix #1251. As per the issue, the page keeps reloading even if hot option is not specified or false. This PR contains fix which disables page reload when hot: false or not specified or hotOnly: true. To enable page refresh along with HMR one has to explicitly set hot: true.

Breaking Changes

No

Additional Info

I think we can consider adding one more option, something like livereload for use-cases when people don't wanna use HMR but instead prefer to go with a regular page refresh. I didn't do it as I feel it's more like a new feature while I tried to keep this PR as simple as possible.

@jsf-clabot
Copy link

jsf-clabot commented Jan 15, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
13 out of 14 committers have signed the CLA.

✅ shellscape
✅ AlexChaseJones
✅ birdwell
✅ ryanwholey
✅ tbroadley
✅ fwielstra
✅ BenoitZugmeyer
✅ evilebottnawi
✅ sokra
✅ abcd-ca
✅ d3viant0ne
✅ yyx990803
✅ byzyk
❌ Bohdan Khodakivskyi


Bohdan Khodakivskyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #1275 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   75.72%   75.77%   +0.05%     
==========================================
  Files           5        5              
  Lines         482      483       +1     
  Branches      156      155       -1     
==========================================
+ Hits          365      366       +1     
  Misses        117      117
Impacted Files Coverage Δ
lib/Server.js 82.02% <66.66%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1ed7a...6bb90e4. Read the comment docs.

@byzyk byzyk closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't enable HMR by default
2 participants