Fix: disable page reload when hot is not specified #1275
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
Aimed to fix #1251. As per the issue, the page keeps reloading even if
hot
option is not specified orfalse
. This PR contains fix which disables page reload whenhot: false
or not specified orhotOnly: true
. To enable page refresh along with HMR one has to explicitly sethot: true
.Breaking Changes
No
Additional Info
I think we can consider adding one more option, something like
livereload
for use-cases when people don't wanna use HMR but instead prefer to go with a regular page refresh. I didn't do it as I feel it's more like a new feature while I tried to keep this PR as simple as possible.