New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addDevServerEntryPoints): exclude client scripts fornode
targets
#1338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 74.02% 74.06% +0.03%
==========================================
Files 10 10
Lines 670 671 +1
==========================================
+ Hits 496 497 +1
Misses 174 174
Continue to review full report at Codecov.
|
node
targets
node
targetsnode
targets
node
targetsnode
targets
@sanonz Are you still interested in eventually continuing this PR ? |
/cc @sanonz |
What else do I need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's wait CI green, if no we need investigate why it is happens and fix it
It's ok? |
@sanonz Yes |
Any idea when this will be resolved into master? It's currently breaking my build. |
Need rebase, CI failed @jojo-apollo feel free to recreate the PR |
Will rebase and create a new PR off this and #1441. |
@jojo-apollo looks this PR also abandoned |
Yup, if he isn't able to reply soon, I'll probably just rebase this PR and move on. |
@sanonz Could you rebase? |
Fixed #1775 |
Type
Issues
node
targets #1441SemVer