Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addDevServerEntryPoints): exclude client scripts fornode targets #1338

Closed
wants to merge 1 commit into from

Conversation

sanonz
Copy link

@sanonz sanonz commented Mar 8, 2018

@jsf-clabot
Copy link

jsf-clabot commented Mar 8, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #1338 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   74.02%   74.06%   +0.03%     
==========================================
  Files          10       10              
  Lines         670      671       +1     
==========================================
+ Hits          496      497       +1     
  Misses        174      174
Impacted Files Coverage Δ
lib/utils/addEntries.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa96a76...01f2413. Read the comment docs.

@sanonz sanonz closed this Aug 15, 2018
@michael-ciniawsky michael-ciniawsky changed the title target node exclude client scripts feat(addDevServerEntryPoints): exclude client scripts fornode targets Aug 26, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.2.0 milestone Aug 26, 2018
@michael-ciniawsky michael-ciniawsky changed the title feat(addDevServerEntryPoints): exclude client scripts fornode targets fix(addDevServerEntryPoints): exclude client scripts fornode targets Aug 26, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(addDevServerEntryPoints): exclude client scripts fornode targets feat(addDevServerEntryPoints): exclude client scripts fornode targets Aug 26, 2018
@michael-ciniawsky
Copy link
Member

@sanonz Are you still interested in eventually continuing this PR ?

@alexander-akait
Copy link
Member

/cc @sanonz

@sanonz
Copy link
Author

sanonz commented Oct 24, 2018

What else do I need to do?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's wait CI green, if no we need investigate why it is happens and fix it

@sanonz
Copy link
Author

sanonz commented Oct 25, 2018

It's ok?

@alexander-akait
Copy link
Member

@sanonz Yes

@j0j00
Copy link

j0j00 commented Dec 20, 2018

Any idea when this will be resolved into master? It's currently breaking my build.

@alexander-akait
Copy link
Member

Need rebase, CI failed

@jojo-apollo feel free to recreate the PR

@j0j00
Copy link

j0j00 commented Dec 21, 2018

Will rebase and create a new PR off this and #1441.

@alexander-akait
Copy link
Member

alexander-akait commented Dec 21, 2018

@jojo-apollo looks this PR also abandoned

@j0j00
Copy link

j0j00 commented Dec 21, 2018

Yup, if he isn't able to reply soon, I'll probably just rebase this PR and move on.

@hiroppy
Copy link
Member

hiroppy commented Apr 5, 2019

@sanonz Could you rebase?

@alexander-akait
Copy link
Member

Fixed #1775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack Multiple Targets
6 participants