Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPDY fails in node >= 11.1.0 #1660

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Fix SPDY fails in node >= 11.1.0 #1660

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e38b654
Fix SPDY fails in node >= 11.1.0
yi-ge Feb 11, 2019
d18fa1c
Update Server.js
yi-ge Feb 11, 2019
b3615b2
Merge branch 'master' into master
yi-ge Feb 11, 2019
6a655ec
Update Server.js
yi-ge Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/Server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const tls = require('tls');
const url = require('url');
const http = require('http');
const https = require('https');
const spdy = require('spdy');
const sockjs = require('sockjs');

const semver = require('semver');
Expand Down Expand Up @@ -635,7 +634,12 @@ class Server {
if (semver.gte(process.version, '10.0.0')) {
this.listeningApp = https.createServer(options.https, app);
} else {
this.listeningApp = spdy.createServer(options.https, app);
/* eslint-disable global-require */
// The relevant issues are:
// https://github.com/spdy-http2/node-spdy/issues/350
// https://github.com/webpack/webpack-dev-server/issues/1592
this.listeningApp = require('spdy').createServer(options.https, app);
/* eslint-enable global-require */
}
} else {
this.listeningApp = http.createServer(app);
Expand Down