feat(client): delete none and warning from clientLogLevel
#1998
+7
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## next #1998 +/- ##
=========================================
- Coverage 92.4% 92.36% -0.05%
=========================================
Files 28 28
Lines 1067 1061 -6
Branches 324 322 -2
=========================================
- Hits 986 980 -6
Misses 77 77
Partials 4 4
Continue to review full report at Codecov.
|
hiroppy
force-pushed
the
feature/modify-loglevel
branch
from
cb7e81a
to
237cfa1
Compare
hiroppy
changed the title
none and warning because they are deprecatednone and warning from clientLogLevel
client-src/default/utils/log.js
Outdated
| case SILENT: | ||
| log.disableAll(); | ||
| break; | ||
| default: | ||
| if (level === 'none' || level === 'warning') { | ||
| log.error('[WDS] "none" and "warning" have been deprecated.'); | ||
| } |
There was a problem hiding this comment.
Remove this, no need this in next release, it is major release
There was a problem hiding this comment.
fm, I want to avoid receiving many issues about these changes from everyone.😞
There was a problem hiding this comment.
ok, I'll delete here but I'll add warn to master maybe. what do you think?
hiroppy
force-pushed
the
feature/modify-loglevel
branch
from
237cfa1
to
c226f5c
Compare
alexander-akait
approved these changes
Jun 10, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 10, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 24, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 24, 2019
knagaitsev
pushed a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 1, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 2, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 5, 2019
hiroppy
added a commit
that referenced
this pull request
Sep 10, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 12, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 18, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 19, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 23, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 24, 2019
alexander-akait
pushed a commit
that referenced
this pull request
Jan 29, 2020
alexander-akait
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: #1901
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
See the title.
Breaking Changes
yes
Additional Info