feat: allow open option to accept an object

lib/options.json

@@ -208,6 +208,9 @@
         },
         {
           "type": "boolean"
+        },
+        {
+          "type": "object"
         }
       ]
     },
@@ -449,7 +452,7 @@
       "mimeTypes": "should be {Object} (https://webpack.js.org/configuration/dev-server/#devservermimetypes-)",
       "noInfo": "should be {Boolean} (https://webpack.js.org/configuration/dev-server/#devservernoinfo-)",
       "onListening": "should be {Function} (https://webpack.js.org/configuration/dev-server/#onlistening)",
-      "open": "should be {String|Boolean} (https://webpack.js.org/configuration/dev-server/#devserveropen)",
+      "open": "should be {String|Boolean|Object} (https://webpack.js.org/configuration/dev-server/#devserveropen)",
       "openPage": "should be {String|Array} (https://webpack.js.org/configuration/dev-server/#devserveropenpage)",
       "overlay": "should be {Boolean|Object} (https://webpack.js.org/configuration/dev-server/#devserveroverlay)",
       "pfx": "should be {String|Buffer} (https://webpack.js.org/configuration/dev-server/#devserverpfx)",

lib/utils/runOpen.js

@@ -11,6 +11,9 @@ function runOpen(uri, options, log) {
   if (typeof options.open === 'string') {
     openOptions = Object.assign({}, openOptions, { app: options.open });
     openOptionValue = `: "${options.open}"`;
+  } else if (typeof options.open === 'object') {
+    openOptions = options.open;
+    openOptionValue = `: "${JSON.stringify(options.open)}"`;
   }
 
   const pages =

test/server/utils/__snapshots__/createConfig.test.js.snap

@@ -802,7 +802,28 @@ Object {
 }
 `;
 
-exports[`createConfig open option (browser) 1`] = `
+exports[`createConfig open option (object) 1`] = `
+Object {
+  "hot": true,
+  "hotOnly": false,
+  "noInfo": true,
+  "open": Object {
+    "app": Array [
+      "Google Chrome",
+      "--incognito",
+    ],
+  },
+  "openPage": "",
+  "port": 8080,
+  "publicPath": "/",
+  "stats": Object {
+    "cached": false,
+    "cachedAssets": false,
+  },
+}
+`;
+
+exports[`createConfig open option (string) 1`] = `
 Object {
   "hot": true,
   "hotOnly": false,

test/server/utils/createConfig.test.js

@@ -855,7 +855,7 @@ describe('createConfig', () => {
     expect(config).toMatchSnapshot();
   });
 
-  it('open option (browser)', () => {
+  it('open option (string)', () => {
     const config = createConfig(
       webpackConfig,
       Object.assign({}, argv, { open: 'Google Chrome' }),
@@ -865,6 +865,19 @@ describe('createConfig', () => {
     expect(config).toMatchSnapshot();
   });
 
+  it('open option (object)', () => {
+    const config = createConfig(
+      webpackConfig,
+      Object.assign({}, argv, {
+        open: {
+          app: ['Google Chrome', '--incognito'],
+        },
+      }),
+      { port: 8080 }
+    );
+    expect(config).toMatchSnapshot();
+  });
+
   it('openPage option', () => {
     const config = createConfig(
       webpackConfig,

test/server/utils/runOpen.test.js

@@ -255,5 +255,31 @@ describe('runOpen util', () => {
         `);
       });
     });
+
+    it('on specify URL with page in Google Chrome incognito mode and log error ', () => {
+      return runOpen(
+        'https://example.com',
+        {
+          open: { app: ['Google Chrome', '--incognito'] },
+          openPage: '/index.html',
+        },
+        logMock
+      ).then(() => {
+        expect(logMock.warn.mock.calls[0][0]).toMatchInlineSnapshot(
+          `"Unable to open \\"https://example.com/index.html\\" in browser: \\"{\\"app\\":[\\"Google Chrome\\",\\"--incognito\\"]}\\". If you are running in a headless environment, please do not use the --open flag"`
+        );
+        expect(opn.mock.calls[0]).toMatchInlineSnapshot(`
+          Array [
+            "https://example.com/index.html",
+            Object {
+              "app": Array [
+                "Google Chrome",
+                "--incognito",
+              ],
+            },
+          ]
+        `);
+      });
+    });
   });
 });