chore(deps): upgrade some deps #2542

hiroppy · 2020-04-28T03:50:00Z

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Update all deps.

Jest has many breaking changes so I modified mocks and some event loop such as setTimeout.

Breaking Changes

yes

Additional Info

fixes: #2541

codecov · 2020-04-28T03:54:00Z

Codecov Report

Merging #2542 into v4 will decrease coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v4    #2542      +/-   ##
==========================================
- Coverage   93.77%   93.36%   -0.41%     
==========================================
  Files          34       34              
  Lines        1334     1327       -7     
  Branches      381      375       -6     
==========================================
- Hits         1251     1239      -12     
- Misses         81       85       +4     
- Partials        2        3       +1

Impacted Files	Coverage Δ
lib/utils/createConfig.js	`96.26% <ø> (-0.20%)`	⬇️
client-src/default/overlay.js	`97.01% <100.00%> (+0.04%)`	⬆️
lib/Server.js	`96.35% <100.00%> (-0.45%)`	⬇️
lib/servers/SockJSServer.js	`93.75% <100.00%> (ø)`
lib/utils/addEntries.js	`100.00% <100.00%> (ø)`
lib/utils/runOpen.js	`100.00% <100.00%> (ø)`
lib/utils/updateCompiler.js	`100.00% <100.00%> (ø)`
client-src/default/utils/reloadApp.js	`86.95% <0.00%> (-13.05%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9b3db...fa6b9ca. Read the comment docs.

hiroppy · 2020-04-28T03:58:02Z

internal-ip doesn't support Node@8. I'll delete it.

    /home/vsts/work/1/s/node_modules/internal-ip/index.js:35
      } catch {}

hiroppy · 2020-04-28T05:14:02Z

puppeteer is breaking when using Node@14 so I downgraded from v3 to v2.
FYI: puppeteer/puppeteer#5719

hiroppy · 2020-04-28T05:31:24Z

CI is green.

alexander-akait · 2020-04-28T11:14:08Z

package.json

-    "yargs": "12.0.5"
+    "webpack-log": "^3.0.1",
+    "ws": "^7.2.5",
+    "yargs": "^15.3.1"


Please do no touch yargs, it can potential break CLI

alexander-akait · 2020-04-28T11:15:00Z

package.json

    "serve-index": "^1.9.1",
    "sockjs": "0.3.20",
    "sockjs-client": "1.4.0",
    "spdy": "^4.0.2",
-    "strip-ansi": "^3.0.1",
-    "supports-color": "^6.1.0",
+    "strip-ansi": "^6.0.0",


We can't do it, we will break client on old browsers, we need setup babel on our client and then do update (let's do backport it from previously next)

alexander-akait

Good job, two things we should not update in this PR

hiroppy · 2020-04-28T11:39:38Z

@evilebottnawi PTAL

alexander-akait

Seems one mistake

alexander-akait · 2020-04-28T13:20:19Z

package.json

@@ -36,39 +36,40 @@
    "release": "standard-version"
  },
  "dependencies": {
+    "@jest/test-sequencer": "^25.4.0",


I think we should move it to devDependencies

hiroppy · 2020-04-28T13:45:35Z

@evilebottnawi updated

alexander-akait · 2020-04-28T14:03:35Z

package.json

-    "ws": "^6.2.1",
-    "yargs": "12.0.5"
+    "webpack-log": "^3.0.1",
+    "ws": "^7.2.5",


/cc @Loonride hope we don't breaking anything, can you look?

This module supports only Node.js so not breaking changes.

based on ws changelog it should be fine

BREAKING CHANGE: the `hot` option is `true` by default, the `hotOnly` option was removed in favor `{ hot: 'only' }`

alexander-akait · 2020-04-28T17:13:05Z

@hiroppy Why do you use feature/upgrade-deps branch for hot: true?

alexander-akait · 2020-04-28T17:13:17Z

No we can't squash this PR

hiroppy · 2020-04-28T20:30:04Z

@evilebottnawi I said you yesterday to merge this branch early as it will be the basis for all our work. The package must be up to date to do all the work because these updated packages are too huge suck as Jest. Yes, we should select rebase and merge when this branch is merged to v4.

knagaitsev · 2020-04-29T06:29:59Z

lib/options.json

+          "type": "boolean"
+        },
+        {
+          "enum": ["only"]


I'm not sure I like this change to the hot option because webpack core CLI also has --hot boolean flag (https://webpack.js.org/api/cli/) and I don't think it's great for usage of a flag of the same name to diverge. This will be annoying to deal with on the webpack-cli serve side, since we parse the webpack flags, then pass any unknown flags along to the dev server. Thoughts?

@Loonride we should implement hot: only on webpack-cli side too

The main problem is that we already have a lot of options and setting up everything is terribly complicated and redundant, we must simplify everything as much as possible

And in some edge cases it is normal what package have same arguments but with many values

BREAKING CHANGE: `lazy` and `filename` options was removed

hiroppy · 2020-04-29T11:22:33Z

NOTE: Must select rebase and merge when merging.

alexander-akait · 2020-04-29T15:42:52Z

@hiroppy @Loonride good job, let's remove inline and live client

I remember we wanted to change the structure of client directory, somebody can take care too!

hiroppy · 2020-04-29T23:51:03Z

@evilebottnawi This PR commit was put together...😞 why did you select squash and merge...? we can't generate the true changelog..

alexander-akait · 2020-04-30T08:57:13Z

@hiroppy Oh, my mistake, anyway I want to put more information to CHANGELOG for new major release, don't worry, I will write it before release

* chore(deps): upgrade deps * style: run prettier * test: update * ci: remove Node@8 * test(cli): add windows support * chore(deps): downgrade puppeteer * chore(deps): downgrade some deps * fix(hot): enable hot option as default (#2546) BREAKING CHANGE: the `hot` option is `true` by default, the `hotOnly` option was removed in favor `{ hot: 'only' }` * fix: remove lazy and filename options (#2544) BREAKING CHANGE: `lazy` and `filename` options was removed

hiroppy added 3 commits April 28, 2020 10:26

chore(deps): upgrade deps

dd12c74

style: run prettier

c0c8e4a

test: update

282ed1d

hiroppy requested review from alexander-akait and knagaitsev as code owners April 28, 2020 03:50

ci: remove Node@8

80fd37c

hiroppy force-pushed the feature/upgrade-deps branch from c1ef6a3 to 6d5b6b1 Compare April 28, 2020 04:38

test(cli): add windows support

e8f54c4

hiroppy force-pushed the feature/upgrade-deps branch from 6d5b6b1 to e8f54c4 Compare April 28, 2020 04:38

chore(deps): downgrade puppeteer

023c194

hiroppy mentioned this pull request Apr 28, 2020

Upgrade "del" dependency #2541

Closed

alexander-akait reviewed Apr 28, 2020

View reviewed changes

alexander-akait requested changes Apr 28, 2020

View reviewed changes

chore(deps): downgrade some deps

39d0213

hiroppy force-pushed the feature/upgrade-deps branch from 3f07520 to 39d0213 Compare April 28, 2020 13:45

alexander-akait reviewed Apr 28, 2020

View reviewed changes

fix(hot): enable hot option as default (#2546)

5e183c0

BREAKING CHANGE: the `hot` option is `true` by default, the `hotOnly` option was removed in favor `{ hot: 'only' }`

knagaitsev reviewed Apr 29, 2020

View reviewed changes

fix: remove lazy and filename options (#2544)

fa6b9ca

BREAKING CHANGE: `lazy` and `filename` options was removed

alexander-akait merged commit 4fc5ecd into v4 Apr 29, 2020

alexander-akait deleted the feature/upgrade-deps branch April 30, 2020 08:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): upgrade some deps #2542

chore(deps): upgrade some deps #2542

hiroppy commented Apr 28, 2020 •

edited

codecov bot commented Apr 28, 2020 •

edited

hiroppy commented Apr 28, 2020

hiroppy commented Apr 28, 2020

hiroppy commented Apr 28, 2020

alexander-akait Apr 28, 2020

alexander-akait Apr 28, 2020

alexander-akait left a comment

hiroppy commented Apr 28, 2020

alexander-akait left a comment

alexander-akait Apr 28, 2020

hiroppy commented Apr 28, 2020

alexander-akait Apr 28, 2020

hiroppy Apr 28, 2020

knagaitsev Apr 29, 2020

alexander-akait commented Apr 28, 2020

alexander-akait commented Apr 28, 2020

hiroppy commented Apr 28, 2020 •

edited

knagaitsev Apr 29, 2020 •

edited

alexander-akait Apr 29, 2020

alexander-akait Apr 29, 2020

alexander-akait Apr 29, 2020

hiroppy commented Apr 29, 2020

alexander-akait commented Apr 29, 2020 •

edited

hiroppy commented Apr 29, 2020

alexander-akait commented Apr 30, 2020

chore(deps): upgrade some deps #2542

chore(deps): upgrade some deps #2542

Conversation

hiroppy commented Apr 28, 2020 • edited

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Apr 28, 2020 • edited

Codecov Report

hiroppy commented Apr 28, 2020

hiroppy commented Apr 28, 2020

hiroppy commented Apr 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

hiroppy commented Apr 28, 2020

alexander-akait left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiroppy commented Apr 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait commented Apr 28, 2020

alexander-akait commented Apr 28, 2020

hiroppy commented Apr 28, 2020 • edited

knagaitsev Apr 29, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiroppy commented Apr 29, 2020

alexander-akait commented Apr 29, 2020 • edited

hiroppy commented Apr 29, 2020

alexander-akait commented Apr 30, 2020

hiroppy commented Apr 28, 2020 •

edited

codecov bot commented Apr 28, 2020 •

edited

hiroppy commented Apr 28, 2020 •

edited

knagaitsev Apr 29, 2020 •

edited

alexander-akait commented Apr 29, 2020 •

edited