fix: add prefix for invalidate endpoint #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EslamHiko
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## v4 #2571 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 35 35
Lines 1313 1313
Branches 368 368
=======================================
Hits 1219 1219
Misses 89 89
Partials 5 5
Continue to review full report at Codecov.
|
hiroppy
previously approved these changes
May 6, 2020
EslamHiko
force-pushed
the
invalidate-prefix
branch
from
8ed9f74
to
07ad1be
Compare
|
CI fails |
hiroppy
previously approved these changes
May 8, 2020
|
@hiroppy I think it is due regression with output |
|
@EslamHiko can you rebase? |
EslamHiko
force-pushed
the
invalidate-prefix
branch
from
07ad1be
to
5d2ce25
Compare
|
@evilebottnawi CI is green 😄 |
hiroppy
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
as @sokra suggested : #2493 (review)
Breaking Changes
a change in the endpoint from
/invalidateto/webpack-dev-server/invalidate.Additional Info