New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HMR/Live Reloading when running against webpack v5 and have an array of targets when using webpack-dev-server v3 #3271
base: v3
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## v3 #3271 +/- ##
=====================================
Coverage ? 93.49%
=====================================
Files ? 34
Lines ? 1337
Branches ? 384
=====================================
Hits ? 1250
Misses ? 85
Partials ? 2 Continue to review full report at Codecov.
|
You can use |
Yes I am aware this is fixed in v4 but due to that version still being in beta my company will not update (Tableau) due to the risk of issue. I was hoping to send this request a few weeks ago but only got permission to make the commit recently. |
Make sense as patch release, I will try to do release in near future |
- Due to bug in webpack dev server. See webpack/webpack-dev-server#3271 JIRA: RAIL-3383
- Due to bug in webpack dev server. See webpack/webpack-dev-server#3271 JIRA: RAIL-3383
@alexander-akait just checking that you are not waiting on me for something, thank you |
Yep, I am here, I am working on |
it would be great indeed to see this change backported to 3.x for compatibility |
Since my company still supports IE11. It fails when I use |
For Bugs and Features; did you add new tests?
Updated the existing
addEntries
web targets testMotivation / Use-Case
Since v4 is not out yet (where this issue is fixed) this fixes the live reload issue #2758 that occurs when a user is using webpack v5.
Breaking Changes
None
Additional Info
Tested against the examples and my own private webpack v5 config to confirm that it detected that the config was a web config.
Looking at the fix in the v4 branch I suspect this will not work as well as that change. Specifically if someone uses the new
browserlists
target option this change won't detect that as a web config. Since this change only needs to hold people over until v4 is released I believe its okay since in the example above the user could just addweb
to their target array.