Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export initialized socket client #4304

Merged
merged 4 commits into from Apr 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion client-src/socket.js
Expand Up @@ -16,7 +16,11 @@ const Client =

let retries = 0;
let maxRetries = 10;
let client = null;

// Initialized client is exported so external consumers can utilize the same instance
// It is mutable to enforce singleton
// eslint-disable-next-line import/no-mutable-exports
export let client = null;

/**
* @param {string} url
Expand Down
17 changes: 16 additions & 1 deletion test/client/socket-helper.test.js
Expand Up @@ -5,7 +5,7 @@
"use strict";

describe("socket", () => {
afterEach(() => {
beforeEach(() => {
jest.resetAllMocks();
jest.resetModules();
});
Expand Down Expand Up @@ -77,4 +77,19 @@ describe("socket", () => {
expect(mockClientInstance.onMessage.mock.calls).toMatchSnapshot();
expect(mockHandler.mock.calls).toMatchSnapshot();
});

it("should export initialized client", () => {
const socket = require("../../client/socket").default;

const nonInitializedInstance = require("../../client/socket").client;
expect(nonInitializedInstance).toBe(null);

socket("my.url", {});

const initializedInstance = require("../../client/socket").client;
expect(initializedInstance).not.toBe(null);
expect(typeof initializedInstance.onClose).toBe("function");
expect(typeof initializedInstance.onMessage).toBe("function");
expect(typeof initializedInstance.onOpen).toBe("function");
});
});