Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor e2e tests to playwright #5080

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link

WIP: will refactors tests one by one and rename the e2e-playwright folder to e2e after its done

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

It will introduce playwright in the project to replace the existing puppeteer end to end framework.

Breaking Changes

Additional Info

WIP: will refactors tests one by one and rename the e2e-playwright folder to e2e after its done
Copy link

linux-foundation-easycla bot commented Mar 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mahdikhashan mahdikhashan changed the title chore: setup playwright chore: refactor e2e tests to playwright Mar 1, 2024
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we need to rewrite existing tests on playwright + some refactor our tests, because we have a lot of code duplication

@mahdikhashan
Copy link
Author

mahdikhashan commented Mar 4, 2024

@alexander-akait thanks for your comment, for participating in the gsoc-2024, is this PR a valid patch requirements? if not could you introduce an issue which I can start working on? I'm a master student and a junior developer. regarding the proposal, is there anything specific things to be mentioned on or do you have a template from the previous years? also, if there is a discord of slack channel which I can share the draft version of proposal and receive early feedback, I appreciate it.

@alexander-akait
Copy link
Member

/cc @evenstensberg

@evenstensberg
Copy link
Member

I think this should work for a gsoc project. (90h project)

@snitin315
Copy link
Member

I think this should work for a gsoc project. (90h project)

Yes, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants