Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Replace rimraf with rm, move rimraf to a dev dep #5162

Merged
merged 1 commit into from Apr 24, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Apr 23, 2024

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No fixes or features

Motivation / Use-Case

Now that this package's minimum supported node version is high enough, and given the relatively simple use case that rimraf is used for at runtime, IMO it's worth just using node's rm instead (via graceful-fs).

There is one more rimraf usage inside a test, but I figured that could stay. Happy to remove that too, though rimraf is still used as a CLI so it has to stay at least as a dev dep.

Breaking Changes

None

Additional Info

None

@alexander-akait
Copy link
Member

Great job 👍

@askoufis
Copy link
Contributor Author

askoufis commented Apr 24, 2024

Should I rename the commit and force push so commitlint will pass?

@alexander-akait
Copy link
Member

Ignore it, I will rename when will merge

@alexander-akait
Copy link
Member

Looks like github actions is down - https://www.githubstatus.com/, I will rerun it when it will work

@alexander-akait alexander-akait merged commit 1a1561f into webpack:master Apr 24, 2024
2 of 39 checks passed
@askoufis askoufis deleted the rimraf-dev-dep branch April 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants