Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(configuration): add electron-preload as available target #3137

Merged
merged 1 commit into from Jun 24, 2019
Merged

docs(configuration): add electron-preload as available target #3137

merged 1 commit into from Jun 24, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Jun 22, 2019 •
edited

This PR adds the electron-preload target option to the configuration/target page.

See webpack/webpack#9188

@netlify
Copy link

netlify bot commented Jun 22, 2019

Preview is ready

Built with commit 32cfe5c

https://deploy-preview-3137--webpackjsorg-netlify.netlify.com

@netlify
Copy link

netlify bot commented Jun 22, 2019

Preview is ready

Built with commit a86e088

https://deploy-preview-3137--webpackjsorg-netlify.netlify.com

@EugeneHlushko
Copy link
Member

Can you please link related merged PR that introduced this target?

@DanielRuf
Copy link
Contributor Author

Can you please link related merged PR that introduced this target?

webpack/webpack#9188

https://github.com/webpack/webpack/search?q=electron-preload&unscoped_q=electron-preload
webpack/webpack@2ec75c1

EugeneHlushko
EugeneHlushko requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. Just a small grammar suggestion. What do you think?

src/content/configuration/target.md Show resolved Hide resolved
EugeneHlushko
EugeneHlushko approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a brief discussion we couldn't improve the and clash and decided to keep as is, consistent with current electron-renderer target sentence struct.

@EugeneHlushko EugeneHlushko merged commit 9dc3e0a into webpack:master Jun 24, 2019
@EugeneHlushko
Copy link
Member

Thanks!

@DanielRuf DanielRuf deleted the docs/configuration-add-electron-preload branch June 24, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRuf @EugeneHlushko @montogeek