Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dev-server.md): Clarify the possible return value for devServer.… #3211

Merged

Conversation

randing89
Copy link
Contributor

Better align the docs with the code changes here: webpack/webpack-dev-server#1696 (comment)
The doc was ambiguous about what false return values does.

@netlify
Copy link

netlify bot commented Jul 25, 2019

Preview is ready

Built with commit 244d82f

https://deploy-preview-3211--webpackjsorg-netlify.netlify.com

Copy link

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randing89
Copy link
Contributor Author

Hi. Can someone merge the PR for me? Thanks.

@mistic
Copy link

mistic commented Jul 28, 2019

@randing89 could you please merge with the last master?

@randing89
Copy link
Contributor Author

@mistic done

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a small change to the text, a question on :void

src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
randing89 and others added 4 commits August 5, 2019 19:22
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
Copy link
Contributor Author

@randing89 randing89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed all the suggestions

@EugeneHlushko EugeneHlushko merged commit 42b249f into webpack:master Aug 13, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants