Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Configuration): document new devServer.overlay options #6809

Merged
merged 2 commits into from May 11, 2023

Conversation

malcolm-kee
Copy link
Contributor

@malcolm-kee malcolm-kee commented May 7, 2023

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.

Resolves

@vercel
Copy link

vercel bot commented May 7, 2023

@malcolm-kee is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@@ -19,7 +19,7 @@ Once you are in the project directory, run the following commands:
- `yarn build` to create a production version of the site.
- `yarn start` to develop on a local webpack-dev-server: [localhost:3000][3].

> NOTE: run `yarn fetch` before running `yarn start` command for the first time
> NOTE: run `yarn fetch-repos` and then `yarn fetch` before running `yarn start` command for the first time
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure if the better solution is to rename fetch-repos script to fetch:repos or update this docs, but definitely this is something that is outdated and blocking first time setup.

@malcolm-kee malcolm-kee force-pushed the config/dev-server-overlay-options branch from 899a7f6 to 03eeeb0 Compare May 7, 2023 13:21
@malcolm-kee malcolm-kee changed the title docs(API): document new devServer.overlay options docs(Configuration): document new devServer.overlay options May 7, 2023
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 1:10am

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this! A few suggestions and then LGTM

src/content/configuration/dev-server.mdx Outdated Show resolved Hide resolved
src/content/configuration/dev-server.mdx Outdated Show resolved Hide resolved
src/content/configuration/dev-server.mdx Outdated Show resolved Hide resolved
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@malcolm-kee
Copy link
Contributor Author

@snitin315 Who should I tag to merge this?

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🎉

@TheLarkInn
Copy link
Member

@chenxsan whats this authorization check I'm happy to force merge but unsure if this is okay?

@snitin315
Copy link
Member

We need to ask @sokra to invite more team members to vercel so that we can also autherize deploy previews.

@snitin315
Copy link
Member

This is good to merge.

@snitin315 snitin315 merged commit 5873fcc into webpack:main May 11, 2023
7 of 8 checks passed
@chenxsan
Copy link
Member

chenxsan commented May 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants