Skip to content

Commit

Permalink
Merge pull request #14244 from webpack/revert-14175-ci/node-version
Browse files Browse the repository at this point in the history
Revert "fix node.js because of v8 bug"
  • Loading branch information
sokra committed Sep 14, 2021
2 parents 562f17a + 76bdcbf commit 20da4b1
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: 16.8.0
cache: "yarn"
node-version: 16.x
cache: 'yarn'
- run: yarn --frozen-lockfile
- uses: actions/cache@v1
with:
Expand All @@ -37,8 +37,8 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: 16.8.0
cache: "yarn"
node-version: 16.x
cache: 'yarn'
- run: yarn --frozen-lockfile
- run: yarn link --frozen-lockfile || true
- run: yarn link webpack --frozen-lockfile
Expand All @@ -54,8 +54,8 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: 16.8.0
cache: "yarn"
node-version: 16.x
cache: 'yarn'
- run: yarn --frozen-lockfile
- run: yarn link --frozen-lockfile || true
- run: yarn link webpack --frozen-lockfile
Expand All @@ -75,7 +75,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [10.x, 16.8.0]
node-version: [10.x, 16.x]
part: [a, b]
include:
- os: ubuntu-latest
Expand All @@ -91,7 +91,7 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: "yarn"
cache: 'yarn'
- run: yarn --frozen-lockfile
- run: yarn link --frozen-lockfile || true
- run: yarn link webpack --frozen-lockfile
Expand Down
14 changes: 7 additions & 7 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: "16.8.0"
versionSpec: "^16.0.0"
displayName: "Install Node.js"
- script: |
curl -o- -L https://yarnpkg.com/install.sh | bash
Expand Down Expand Up @@ -125,10 +125,10 @@ jobs:
node_version: ^12.4.0
part: b
node-16-a:
node_version: 16.8.0
node_version: ^16.0.0
part: a
node-16-b:
node_version: 16.8.0
node_version: ^16.0.0
part: b
steps:
- task: NodeTool@0
Expand Down Expand Up @@ -189,10 +189,10 @@ jobs:
node_version: ^14.0.0
part: a
node-16-a:
node_version: 16.8.0
node_version: ^16.0.0
part: a
node-16-b:
node_version: 16.8.0
node_version: ^16.0.0
part: b
steps:
- task: NodeTool@0
Expand Down Expand Up @@ -251,10 +251,10 @@ jobs:
node_version: ^12.4.0
part: b
node-16-a:
node_version: 16.8.0
node_version: ^16.0.0
part: a
node-16-b:
node_version: 16.8.0
node_version: ^16.0.0
part: b
steps:
- task: NodeTool@0
Expand Down

0 comments on commit 20da4b1

Please sign in to comment.