Merge pull request #8511 from isiahmeadows/fix-erroneous-injection

Remove a broken hook

lib/node/NodeSourcePlugin.js

@@ -116,9 +116,6 @@ module.exports = class NodeSourcePlugin {
 				normalModuleFactory.hooks.parser
 					.for("javascript/dynamic")
 					.tap("NodeSourcePlugin", handler);
-				normalModuleFactory.hooks.parser
-					.for("javascript/esm")
-					.tap("NodeSourcePlugin", handler);
 			}
 		);
 		compiler.hooks.afterResolvers.tap("NodeSourcePlugin", compiler => {

test/configCases/web/node-source/index.mjs

@@ -0,0 +1,12 @@
+// Block `require`, but keep Webpack from trying to work around it.
+eval("require = undefined")
+
+it("should compile fine", () => {
+    // It's okay if this executes fine or if `global` is not defined. If it
+    // results in a `require()` call, this will throw a `TypeError` instead.
+    try {
+        global
+    } catch (e) {
+        if (!(e instanceof ReferenceError)) throw e
+    }
+})

test/configCases/web/node-source/webpack.config.js

@@ -0,0 +1,10 @@
+module.exports = {
+	target: "web",
+	entry: "./index.mjs",
+	performance: {
+		hints: false
+	},
+	optimization: {
+		minimize: false
+	}
+};