Merge pull request #7798 from webpack/bugfix/empty-chunks-fail

fix case where empty chunkgroups cause nested chunkgroups to vanish
webpack · Jul 27, 2018 · 6c60e9d · 6c60e9d
2 parents a28f44f + aac4368
commit 6c60e9d
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -1572,6 +1572,9 @@ class Compilation extends Tapable {
 		/** @type {Map<DependenciesBlock, ChunkGroup>} */
 		const blockChunkGroups = new Map();
 
+		/** @type {Set<DependenciesBlock>} */
+		const blocksWithNestedBlocks = new Set();
+
 		const ADD_AND_ENTER_MODULE = 0;
 		const ENTER_MODULE = 1;
 		const PROCESS_BLOCK = 2;
@@ -1731,6 +1734,10 @@ class Compilation extends Tapable {
 
 						// Traverse all Blocks
 						iterationOfArrayCallback(blockInfo.blocks, iteratorBlock);
+
+						if (blockInfo.blocks.length > 0 && module !== block) {
+							blocksWithNestedBlocks.add(block);
+						}
 						break;
 					}
 					case LEAVE_MODULE: {
@@ -1792,6 +1799,7 @@ class Compilation extends Tapable {
 		 */
 		const filterFn = dep => {
 			const depChunkGroup = dep.chunkGroup;
+			if (blocksWithNestedBlocks.has(dep.block)) return true;
 			if (areModulesAvailable(depChunkGroup, newAvailableModules)) return false; // break all modules are already available
 			return true;
 		};

diff --git a/test/cases/chunks/nested-in-empty/a.js b/test/cases/chunks/nested-in-empty/a.js
diff --git a/test/cases/chunks/nested-in-empty/b.js b/test/cases/chunks/nested-in-empty/b.js
@@ -0,0 +1 @@
+module.exports = 42;
diff --git a/test/cases/chunks/nested-in-empty/index.js b/test/cases/chunks/nested-in-empty/index.js
@@ -0,0 +1,13 @@
+it("should include a chunk nested in an empty chunk", (done) => {
+	require.ensure(["./a"], () => {
+		require.ensure([], () => {
+			require.ensure(["./a"], () => {
+				require.ensure([], () => {
+					const b = require("./b");
+					expect(b).toBe(42);
+					done();
+				});
+			});
+		});
+	});
+});