Merge pull request #11948 from jantimon/fix/plugin-types

fixes "Type '(compiler: Compiler) => void' is not assignable to type '() => void'.ts"

lib/Compilation.js

@@ -76,6 +76,8 @@ const { getRuntimeKey } = require("./util/runtime");
 /** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("../declarations/WebpackOptions").EntryDescriptionNormalized} EntryDescription */
 /** @typedef {import("../declarations/WebpackOptions").OutputNormalized} OutputOptions */
+/** @typedef {import("../declarations/WebpackOptions").WebpackPluginFunction} WebpackPluginFunction */
+/** @typedef {import("../declarations/WebpackOptions").WebpackPluginInstance} WebpackPluginInstance */
 /** @typedef {import("./AsyncDependenciesBlock")} AsyncDependenciesBlock */
 /** @typedef {import("./Cache")} Cache */
 /** @typedef {import("./CacheFacade")} CacheFacade */
@@ -115,11 +117,6 @@ const { getRuntimeKey } = require("./util/runtime");
  * @returns {any}
  */
 
-/**
- * @typedef {Object} Plugin
- * @property {() => void} apply
- */
-
 /** @typedef {new (...args: any[]) => Dependency} DepConstructor */
 /** @typedef {Record<string, Source>} CompilationAssets */
 
@@ -3321,7 +3318,7 @@ This prevents using hashes of each other and should be avoided.`
 	 *
 	 * @param {string} name name of the child compiler
 	 * @param {OutputOptions} outputOptions // Need to convert config schema to types for this
-	 * @param {Plugin[]} plugins webpack plugins that will be applied
+	 * @param {Array<WebpackPluginInstance | WebpackPluginFunction>} plugins webpack plugins that will be applied
 	 * @returns {Compiler} creates a child Compiler instance
 	 */
 	createChildCompiler(name, outputOptions, plugins) {

types.d.ts

@@ -1501,7 +1501,10 @@ declare class Compilation {
 	createChildCompiler(
 		name: string,
 		outputOptions: OutputNormalized,
-		plugins: Plugin[]
+		plugins: (
+			| ((this: Compiler, compiler: Compiler) => void)
+			| WebpackPluginInstance
+		)[]
 	): Compiler;
 	checkConstraints(): void;
 
@@ -6663,9 +6666,6 @@ declare interface PerformanceOptions {
 	 */
 	maxEntrypointSize?: number;
 }
-declare interface Plugin {
-	apply: () => void;
-}
 declare interface PnpApiImpl {
 	resolveToUnqualified: (arg0: string, arg1: string, arg2?: any) => string;
 }