Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HotModuleReplacement.runtime.js #11522

Closed
wants to merge 1 commit into from
Closed

Update HotModuleReplacement.runtime.js #11522

wants to merge 1 commit into from

Conversation

infoeon
Copy link

@infoeon infoeon commented Sep 24, 2020

Add support for webpack_require.nc and other properties on webpack_require that are non-existent when HMR is injected.

What kind of change does this PR introduce?

This resolves issues such as webpack-contrib/style-loader#427

Does this PR introduce a breaking change?

This feature will not work on IE as it does not support Proxy, but IE should not be supported anyways.

Add support for __webpack_require__.nc and other properties on __webpack_require__ that are non-existent when HMR is injected.  This resolves issues such as webpack-contrib/style-loader#427
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@infoeon infoeon closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants