Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added with { type: "json" } #17230

Merged
merged 1 commit into from
May 23, 2023

test: added `with { type: "json" }`

456a811
Select commit
Failed to load commit list.
Merged

test: added with { type: "json" } #17230

test: added `with { type: "json" }`
456a811
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded May 19, 2023 in 20s

Analysis complete

Summary

Updated acorn-import-assertions dependency to support import assertions for JSON modules. Added test cases and log files to verify the feature and the error handling.

Walkthrough

  • Update acorn-import-assertions dependency to support import assertions syntax for JSON modules (link)

  • Add test cases for importing JSON data with and without type assertions and extensions (link)

    • Check that importing a JS file with a JSON type assertion throws an error (link, link, link)
    • Use infrastructure-log.js to capture the expected error message from webpack (link)

    Poem

    acorn supports JSON

import assertions in webpack
falling leaves, errors

Emoji

✨✅🐛

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 17.9 seconds
package.json ✅ Finished 9.8 seconds
test/cases/json/import-with-type-json/errors.js ✅ Finished 9.8 seconds
test/cases/json/import-with-type-json/import-poison.js ✅ Finished 9.8 seconds
test/cases/json/import-with-type-json/index.js ✅ Finished 9.8 seconds
test/cases/json/import-with-type-json/infrastructure-log.js ✅ Finished 9.8 seconds