feat: resolve style fields in package json #17346
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -704,24 +704,16 @@ const applyModuleDefaults = ( | |
| }); | ||
| } | ||
| if (css) { | ||
| const cssRule = { | ||
| type: CSS_MODULE_TYPE, | ||
| resolve: { | ||
| fullySpecified: true, | ||
| preferRelative: true | ||
| } | ||
| }; | ||
| const cssModulesRule = { | ||
| type: "css/module", | ||
| resolve: { | ||
| fullySpecified: true | ||
| } | ||
| }; | ||
|
|
@@ -1443,6 +1435,14 @@ const getResolveDefaults = ({ cache, context, targetProperties, mode }) => { | |
| extensions: [...jsExtensions] | ||
| }); | ||
|
|
||
| /** @type {function(): ResolveOptions} */ | ||
| const styleDeps = () => ({ | ||
| conditionNames: ["style"], | ||
| mainFields: ["style", "main", "..."], | ||
| mainFiles: ["index", "..."], | ||
|
There was a problem hiding this comment. I don't think we need it here, becaue it will resolve There was a problem hiding this comment. So we need a test case here too |
||
| extensions: [".css", "..."] | ||
|
There was a problem hiding this comment. Not sure about There was a problem hiding this comment. |
||
| }); | ||
|
|
||
| /** @type {ResolveOptions} */ | ||
| const resolveOptions = { | ||
| cache, | ||
|
|
@@ -1472,7 +1472,8 @@ const getResolveDefaults = ({ cache, context, targetProperties, mode }) => { | |
| // for backward-compat: Custom Dependency | ||
| unknown: cjsDeps(), | ||
| // for backward-compat: getResolve without dependencyType | ||
| undefined: cjsDeps(), | ||
| "css-import": styleDeps() | ||
|
There was a problem hiding this comment. What do you think rename it to just There was a problem hiding this comment. CSS is already a module type. Wont that cause a collision? After renaming css-import to css in ExternalModule and CSSModule, the snapshots are failing. There was a problem hiding this comment. Should not because, it is just a dependecy type |
||
| } | ||
| }; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need the
mainhere, because it already in list, please try to remove it from here and test it