New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bad module order and missing modules when optimizing side effect free modules #18302
base: main
Are you sure you want to change the base?
Conversation
|
For maintainers only:
|
b97c64a
to
f736322
Compare
3808d61
to
19ddc26
Compare
@alexander-akait There's further explanation in the test file: https://github.com/webpack/webpack/pull/18302/files#diff-704c7db65db3c626574febb499039bd28ea77e5675747e9924b6e3738cda11a9R13 Also you might find this interesting https://github.com/webpack/webpack/pull/18302/files#diff-d7226814b80e1c9c596f24913bb3c05e1ea96def6c20a1313433f225fa4996d8R1 |
19ddc26
to
be3cb13
Compare
Thank you, I see the problem, let's try a fix from #7094 (comment) and look at our tests |
I removed the block that handles 14 test cases in
|
Yeah, I see it, need to investigate it |
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
A temporary failed case so far
I made this test under a temp name, I'll tidy it up, give it a proper name and move it to a proper location once I figure out what exactly is the issue.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing
fixes #7094 (hopefully, since this issue evolved over time and covers multiple problems)