Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css/global not handle the exports name #18341

Merged
merged 3 commits into from Apr 22, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 20, 2024

According the definition of the css/global and css module type, css/global should handle the exports name, css shouldn't, but now is reversed, this PR aimed to fix that.

Besides that, this PR also does:

  • the ident of @keyframe and @property should keep it as is in css/global
  • exportsConvention is not needed for css module type, since :export is a css/global css/module feature, so remove it from css generator options

What kind of change does this PR introduce?

Did you add tests for your changes?

updated snapshot

Does this PR introduce a breaking change?

yes, exportsConvention is remove from css generator options

What needs to be documented once your changes are merged?

update css generator options

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait alexander-akait merged commit 4b50219 into webpack:main Apr 22, 2024
54 of 56 checks passed
@ahabhgk ahabhgk deleted the fix-css-type branch April 23, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants