feat: support css esModule generator options #18357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
|
||
| it("should able to require the css module as commonjs", () => { | ||
| const style = require("./style.module.css"); | ||
| console.log(style) |
There was a problem hiding this comment.
Let's remove it from here
| // TODO webpack 6: remove /\[moduleid\]/.test | ||
| if ( | ||
| /\[id\]/.test(this.localIdentName) || | ||
| /\[moduleid\]/.test(this.localIdentName) |
There was a problem hiding this comment.
I think we can improve it in future PRs
Could you elaborate? Actually I didn't understand what you mean. Did you mean we don't need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature, introduce
esModule: falsefor css generator optionsDid you add tests for your changes?
Added
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
esModule css generator options