New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add per chunk index and index2 #7603
Conversation
refactor index generation
For maintainers only:
|
@sokra can you provide link on issue? |
After this PR MCEP can use the per chunk group index to get the module order: There could still be cases where order can be done correctly (i. e. when extracting modules into a common chunk). It could make sense to emit a warning in these cases (but that probably annoy users since it doesn't matter in most cases). |
cc @bawjensen |
@sokra i.e no additional work in MCEP? |
# Conflicts: # test/__snapshots__/StatsTestCases.test.js.snap
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Is there any reason why stats object is now different due to this PR? And, what's even more confusing, only when running webpack-serve, but not with standard one time build? I'm using StatsWriterPlugin to generate a JSON file with entry points: This is what I get out of stats file with following versions:
{
"entrypoints": {
"bundle": {
"chunks": [
"vendors~bundle", "bundle"
],
"assets": [
"chunks/vendors~bundle.js", "bundle.js"
],
"children": {},
"childAssets": {}
}
}
} And this is what I get now with this PR included, but only with webpack-serve:
{
"entrypoints": {
"bundle": {
"chunks": [
63, 64, 65, 66, 70,
"vendors~bundle", "bundle"
],
"assets": [
"chunks/63.js", "chunks/64.js", "chunks/65.js", "chunks/66.js", "chunks/70.js",
"chunks/vendors~bundle.js", "bundle.js"
],
"children": {},
"childAssets": {}
}
}
}
|
refactor index generation
What kind of change does this PR introduce?
feature, bugfix for MCEP
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing