Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-commitlint): handling of parserPreset when it's not a string #632

Merged
merged 2 commits into from May 13, 2024

Conversation

RebeccaStevens
Copy link
Contributor

fix #631

@RebeccaStevens
Copy link
Contributor Author

@webpro Do you want me to include a test with this?
If so, should I just modify packages/knip/fixtures/plugins/commitlint/commitlint.config.js but changing out the parserPreset value?

@webpro
Copy link
Owner

webpro commented May 12, 2024

Thanks for the PR!

@webpro Do you want me to include a test with this? If so, should I just modify packages/knip/fixtures/plugins/commitlint/commitlint.config.js but changing out the parserPreset value?

Yes, that would be great. And then maybe add that string value to the other config file so we still have both types covered.

@webpro webpro merged commit d7b2545 into webpro:main May 13, 2024
11 of 14 checks passed
@webpro
Copy link
Owner

webpro commented May 14, 2024

🚀 This pull request is included in v5.16.0. See Release 5.16.0 for release notes.

Using Knip in a commercial project? Please consider sponsoring me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commitlint plugin update breaks when parserPreset isn't a string
2 participants