Failsafe if it fails to % - encode headers #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Warcio fails to % encode headers, at least when dealing with the exception replace the non-encodeable chracters with a stub. This is not an ideal fix, but at least WARCIO does not fail to decode and encode the same file and the most probable outcome is that a strange cookie gets a few chars replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Warcio fails to % encode headers, at least when dealing with the exception replace the non-encodeable chracters with a stub. This is not an ideal fix, but at least WARCIO does not fail to decode and encode the same file and the most probable outcome is that a strange cookie gets a few chars replaced.
Temporary fix for issue: #128
Until headers are treated as a byte stream when reencoding a file.