Skip to content

Commit

Permalink
[dist] 1.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@3rd-Eden
3rd-Eden committed Apr 11, 2016
1 parent 24625ac commit 4263f26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Einar Otto Stangvik <einaros@gmail.com> (http://2x.io)",
"name": "ws",
"description": "simple to use, blazing fast and thoroughly tested websocket client, server and console for node.js, up-to-date against RFC-6455",
"version": "1.0.1",
"version": "1.1.0",
"license": "MIT",
"main": "index.js",
"keywords": [
Expand Down

8 comments on commit 4263f26

@joshdick
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3rd-Eden Will this release be published to npm soon? It contains a change that would help something I'm working on! Thanks very much!

@3rd-Eden
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdick It is in npm actually, I tried to publish again and it said:

npm ERR! "You cannot publish over the previously published version 1.1.0." : ws

@3rd-Eden
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just really weird that https://www.npmjs.com/package/ws shows 1.0.1 but when we do npm view ws it does show:

  description: 'simple to use, blazing fast and thoroughly tested websocket client, server and console for node.js, up-to-date against RFC-6455',
  'dist-tags': { latest: '1.1.0' },

@ericmdantas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, when I install I also get the 1.1.0 version:

`-- ws@1.1.0
  +-- options@0.0.6
  `-- ultron@1.0.2

@joshdick
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3rd-Eden Oh wow, I didn't see 1.1.0 on https://www.npmjs.com/package/ws so I assumed it hadn't been published.

Is it possible that npm's site is somehow affected by GitHub releases? I ask since 1.0.1 is currently denoted as "latest release" on https://github.com/websockets/ws/releases .

@3rd-Eden
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdick Nope, it should just use the latest published version as "latest" on npm.

@vphantom
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still though, is 1.1.0 in fact a release? If so it'd make sense to create one on the GitHub side as was done previously. I too was confused by the difference between NPM's 1.0.1 and here when trying to distinguish Node vs browser use cases.

@YurySolovyov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just release as 1.1.1 or 1.2.0?

Please sign in to comment.