Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide http server port directly from _server #1294

Merged
merged 10 commits into from
Feb 5, 2018
Merged

Provide http server port directly from _server #1294

merged 10 commits into from
Feb 5, 2018

Commits on Feb 4, 2018

  1. provide http server port directly from _server

    Tossapon Nuanchuay committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    8af5c88 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. fix from review

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    3e955f6 View commit details
    Browse the repository at this point in the history

  2. write test to support node v4

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    3b4f124 View commit details
    Browse the repository at this point in the history

  3. refactor code follow code review

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    b4ffa36 View commit details
    Browse the repository at this point in the history

  4. test start server mode noServer cann't call address()

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    66502a0 View commit details
    Browse the repository at this point in the history

  5. refactor code follow by code review

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    a0b62e9 View commit details
    Browse the repository at this point in the history

  6. Update ws.md

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    df4ff2e View commit details
    Browse the repository at this point in the history

  7. use regex in test, and swap arg in assertion

    Tossapon Nuanchuay committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    34b3fb6 View commit details
    Browse the repository at this point in the history

  8. Fix nits

    @lpinca
    lpinca committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    0ef1ae1 View commit details
    Browse the repository at this point in the history

  9. Fix nits

    @lpinca
    lpinca committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    cc9309e View commit details
    Browse the repository at this point in the history