Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate verifyClient #1613

Merged
merged 7 commits into from
Aug 4, 2019

Conversation

adrianhopebailie
Copy link
Contributor

I submitted #1612 to update verifyClient because I was unaware of #377 (comment)

This discussion has been going on since 2014 so I figured it would be useful to update some of the examples and docs to save someone else from making the mistake I did 馃槃

This change:

  • Updates the README with a client auth example
  • Updates the existing express-sessions example to stop using verifyClient
  • Put notes in the docs to discourage the use of verifyClient

@lpinca
Copy link
Member

lpinca commented Aug 4, 2019

Thank you for this, rubber stamp LGTM. There are a few nits I would like to address. I will specify them later.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/ws.md Outdated Show resolved Hide resolved
examples/express-session-parse/public/app.js Show resolved Hide resolved
lib/websocket-server.js Outdated Show resolved Hide resolved
adrianhopebailie and others added 4 commits August 4, 2019 20:55
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
README.md Show resolved Hide resolved
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca lpinca merged commit 0a61236 into websockets:master Aug 4, 2019
@lpinca
Copy link
Member

lpinca commented Aug 4, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants