docs: clarify legacy deps #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry about that. In order to satisfy the requirements, I have updated this PR to delineate the information into two sections, one of which is clearly for legacy consumers of the library. |
lpinca
reviewed
Dec 19, 2023
|
Can you also please use a more descriptive commit message? |
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
|
i assume by commit message you mean PR title, so I changed that now |
|
No, I meant the commit message title, but I can change it before merging. |
lpinca
reviewed
Dec 19, 2023
lpinca
reviewed
Dec 19, 2023
lpinca
reviewed
Dec 19, 2023
|
Please fix the formatting issues. |
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
|
done |
lpinca
reviewed
Dec 20, 2023
lpinca
reviewed
Dec 20, 2023
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
isUtf8is automatically present in modern versions of Node.js, we can cleanup this old info that doesn't apply anymore in order to simplify things and make the docs easier to read.(It's also a footgun for people reading this passage and then installing both
bufferutilandutf-8-validate.)