Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty core Handler that wraps Spring HttpHandler as an adaptor #1

Closed
wants to merge 48 commits into from

Conversation

gregw
Copy link
Member

@gregw gregw commented Jan 15, 2024

Implement a Jetty core Handler that uses a spring HttpHandler without the overhead of servlets and using reactive async abstraction.

@lachlan-roberts
Copy link
Member

@gregw you should be able to assign to me now

@gregw gregw requested review from sbordet and lorban January 15, 2024 08:15
@gregw gregw changed the title Initial boiler plate implementation of JettyCore HttpHandler Adaptor JettyCore Handler that wraps Spring HttpHandler Jan 15, 2024
@gregw gregw changed the title JettyCore Handler that wraps Spring HttpHandler Jetty core Handler that wraps Spring HttpHandler as an adaptor Jan 15, 2024
@gregw gregw changed the title Jetty core Handler that wraps Spring HttpHandler as an adaptor Jetty core Handler that wraps Spring HttpHandler as an adaptor Jan 15, 2024
@gregw
Copy link
Member Author

gregw commented Jan 18, 2024

@lachlan-roberts see jetty/jetty.project#11288, which contains a fix to the Content.Sink.Subscriber that you may need to make this work

@lachlan-roberts
Copy link
Member

@gregw I have pushed the commits to implement the write side.
All tests inside spring-web/src/test are passing now.

@gregw
Copy link
Member Author

gregw commented Jan 24, 2024

@lachlan-roberts what was the conclusion about websocket upgrade?

@gregw
Copy link
Member Author

gregw commented Jan 24, 2024

I've opened draft spring-projects#32097 to solicit more feedback

@gregw
Copy link
Member Author

gregw commented Jan 24, 2024

@lachlan-roberts unsurprisingly, we are failing websocket tests: org.springframework.web.reactive.socket.WebSocketIntegrationTests

@lachlan-roberts
Copy link
Member

WebSocket tests are passing now.

There is a WebSocketClient with implementations from netty, tomcat and undertow.
So adding this to my TODO to write a Jetty implementation for this.

gregw and others added 21 commits February 6, 2024 10:25
Jetty has an unset response status of 0, this should be converted to 200 for spring.
When mutating the request, a mutable HttpFields instance is created.
Spring appears to want the unadulterated raw path complete with parameters etc.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…cookies

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the JettyCoreHttpHandlerAdapter branch from 53af169 to bbd2573 Compare February 6, 2024 00:41
@gregw
Copy link
Member Author

gregw commented Mar 22, 2024

Closed in favor of spring-projects#32097

@gregw gregw closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants