Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by use of API from older Multipart versions #246

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rogerluan
Copy link
Contributor

@rogerluan rogerluan commented Apr 16, 2023

This error was happening when attempting to run wti push <filepath>:

image

This PR fixes this.

@edouard
Copy link
Collaborator

edouard commented Apr 17, 2023

@rogerluan Thanks for the PR! I'll review it today. Did you encounter this issue when using fastlane with multipart_post locked to version 2.0?

@rogerluan
Copy link
Contributor Author

@edouard Yes: multipart-post (2.0.0) and fastlane (2.212.1)

@rogerluan
Copy link
Contributor Author

Which just reminded me... my changes might not work for those using multipart <2.0 😅

I think we could either enforce multipart to be >=2.0, or we'll have to add runtime checks to see which API is available 😬

@edouard
Copy link
Collaborator

edouard commented Apr 18, 2023

Which just reminded me... my changes might not work for those using multipart <2.0 😅

I think we could either enforce multipart to be >=2.0, or we'll have to add runtime checks to see which API is available 😬

I think it's fine to require multipart_post >= 2.0. The 2.0 version of multipart_post was released in 2013 so it's not like the cutting edge version of that library 😅

I wish @fastlane would relax that dependency on multipart_post though, I’m not sure why it’s locked to a 10 years old version of that library. I've created a pull request fastlane/fastlane#20870 but it hasn't been merged yet.

@edouard edouard merged commit 5d00daf into webtranslateit:main Apr 18, 2023
1 check passed
@rogerluan
Copy link
Contributor Author

I've reviewed your PR in fastlane repo and approved it @edouard 🙏 please take a look at it again 😊

Thanks for getting this merged nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants