irc: allow specifying SSL CA per server #1262
Open
+125
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
commented
Oct 6, 2018
| hook_connect->callback_data, | ||
| *HOOK_CONNECT(hook_connect, gnutls_sess), | ||
| NULL, 0, NULL, 0, NULL, | ||
| WEECHAT_HOOK_CONNECT_GNUTLS_CB_INIT_XCRED); |
There was a problem hiding this comment.
Maybe this isn't the best to call the GnuTLS callbacks function when simply initializing the trust list because strictly it isn't a callback for a GnuTLS function. INIT_XCRED could also be added as a case under the usual hook_connect callback if that's more appropriate, although to me it seems more related to using GnuTLS specifically and most connections will not need to touch that part.
Of the GnuTLS functions used for this implementation the highest version requirement is >=3.3.0 for gnutls_credentials_get.
sim642
force-pushed
the
gnutls-server-ca
branch
from
47ab1de
to
8d031ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
- Coverage 27.69% 27.66% -0.03%
==========================================
Files 201 201
Lines 81939 81976 +37
==========================================
- Hits 22693 22681 -12
- Misses 59246 59295 +49
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438.
This PR is an improvement of PR #613 (credit to @ManiacTwister), which started in the right direction but has some still unresolved issues:
hook_connectstill have no way to manipulate the trust list for their connection only.This PR tries to solve these problems and hopefully finally bring per server SSL CAs to weechat. Every
hook_connectuser can choose to manipulate the trust list however they see fit: clear it (or not), add CAs from file (or elsewhere).Turns out GnuTLS >=3.3.0 is required to manipulate the trust list like this. This is a significantly higher requirement than otherwise is needed but it only affects the added
ssl_ca_fileoption use and should be fine on most cases (even the old Ubuntu 16.04 has GnuTLS 3.4).Happy Hacktoberfest!