Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix beginning of line in iterated regexec (closes #1521) #1523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Jun 10, 2020

Besides the original issue in eval_replace_regex I found three more iterated regexec calls where similar issue can be observed. I added tests for all four.

@sim642 sim642 added the bug Unexpected problem or unintended behavior label Jun 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #1523 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   35.04%   35.05%           
=======================================
  Files         204      204           
  Lines       84373    84382    +9     
=======================================
+ Hits        29571    29581   +10     
+ Misses      54802    54801    -1     
Impacted Files Coverage Δ
src/core/wee-eval.c 91.96% <100.00%> (+0.01%) ⬆️
src/core/wee-string.c 88.53% <100.00%> (+0.08%) ⬆️
src/gui/gui-color.c 80.24% <100.00%> (+0.04%) ⬆️
src/plugins/buflist/buflist-bar-item.c 12.64% <0.00%> (-0.05%) ⬇️
src/gui/gui-chat.c 70.62% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad07d1...559ba8c. Read the comment docs.

@sim642 sim642 marked this pull request as draft June 11, 2020 06:36
@sim642 sim642 marked this pull request as ready for review June 11, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants