irc: add pointer "irc_server" and "irc_channel" in hashtable sent to buflist bar item hook focus callback (closes #1543) #1575
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buflist bar item hook focus callback (closes weechat#1543)
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
=========================================
Coverage ? 35.26%
=========================================
Files ? 204
Lines ? 84765
Branches ? 0
=========================================
Hits ? 29893
Misses ? 54872
Partials ? 0
Continue to review full report at Codecov.
|
sim642
commented
Oct 18, 2020
Comment on lines
+834
to
+839
| weechat_hook_focus ("buflist", | ||
| &irc_bar_item_focus_buflist, NULL, NULL); | ||
| weechat_hook_focus ("buflist2", | ||
| &irc_bar_item_focus_buflist, NULL, NULL); | ||
| weechat_hook_focus ("buflist3", | ||
| &irc_bar_item_focus_buflist, NULL, NULL); |
There was a problem hiding this comment.
This is slightly copy-paste-ish but that's the only way in irc plugin to take care of all the buflists without having a weird dependency on the buflist plugin's constant. This could be improved by allowing wildcards in hook_focus area names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1543.
TODO when merging
buflistbar item extra focus variables underhook_focusin plugin API docs.irc_serverandirc_channelto that table with corresponding WeeChat version constraint.