-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relay: Add "sync * hotlist" option #1724
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the small point noted in the comment, seems OK for me!
I'll update the docs in a separate commit.
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
- Coverage 37.26% 37.25% -0.02%
==========================================
Files 209 209
Lines 84606 84633 +27
==========================================
Hits 31527 31527
- Misses 53079 53106 +27
Continue to review full report at Codecov.
|
PR converted to draft as I'm observing weechat crashes with these changes. I'm investigating. |
Would this allow for sending the hotlist state from the relay to the clients, so kind of the reverse of what is already there with clients sending their read status? |
…age instead of adding line pointer to all line_data structs
@2xsaiko yeah, sure. it saves you from syncing on all buffers while still giving you notice of highlights etc. |
@flashcode What would be missing to get this change merged? |
We have to check if the add of line hdata could be problematic for existing clients. It should not, but it depends how the clients implement the protocol, it can break. Once we validated the major relay clients are OK with this change, this can be merged (I'll add appropriate documentation as well). Did you test some relay clients with these changes? |
Hi,
this PR adds an option for a relay client to sync on the "hotlist_changed" hook signal.
Please review and let me know if anything should be changed.
TODO: Update documentation.