don't require account-notify/away-notify for WHOX

[jesopo]

when you connect weechat to znc, you first get a CAP dance like this:

-> :irc.znc.in CAP unknown-nick LS :batch cap-notify echo-message multi-prefix server-time userhost-in-names znc.in/batch znc.in/self-message znc.in/server-time-iso
<- CAP REQ :cap-notify multi-prefix server-time userhost-in-names
<- CAP END
-> @time=2022-07-10T20:19:26.599Z :irc.znc.in CAP * ACK :cap-notify multi-prefix server-time userhost-in-names

and then once znc has figured out what network you're connecting to, you get this:

-> @time=2022-07-10T20:19:26.608Z :irc.znc.in CAP user NEW :account-notify away-notify extended-join
<- CAP REQ :account-notify away-notify extended-join

and then it takes until after znc has already finished replaying NAMES to you for you to get this

-> @time=2022-07-10T20:19:26.621Z :irc.znc.in CAP user ACK :account-notify away-notify extended-join

which means by the time you're hitting the code that I'm changing, you don't know that the network you're on supports away-notify or account-notify, which means this if will reliably fail and weechat simply won't send a WHOX request. this can be solved by simply sending WHOX whenever a network supports it.

[jesopo]

an alternative solution is to check what CAPs you know the other side has said they support, rather than checking what's actually been ACKed, but that seems untidy

[codecov-commenter]

Codecov Report

Merging #1793 (9813401) into master (e057c16) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   38.05%   38.04%   -0.02%     
==========================================
  Files         211      211              
  Lines       85672    85665       -7     
==========================================
- Hits        32605    32592      -13     
- Misses      53067    53073       +6     

Impacted Files	Coverage Δ
src/plugins/irc/irc-channel.c	53.36% <75.00%> (-1.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e057c16...9813401. Read the comment docs.

[flashcode]

Hello,
You are removing the use of options away_check and away_check_max_nicks (this one becomes completely unused in IRC plugin), is that wanted?

[jesopo]

yes, I don't think there's a reason to ever not use WHOX when it is available

[flashcode]

But these options are there to let the user enable or disable WHO (or WHOX), based on how many nicks are in the channel. Purpose is to limit the bandwith used (WHO responses can be huge on some channels).

Using WHOX when available is OK for me, but I would like to keep the feature to completely disable WHO(X) if needed.

[jesopo]

fair enough. i'll tweak the PR in a bit