qa: update to symfony/console 5.1.2, remove workarounds

symfony/console 5.1.2 incorporates
symfony/symfony#37160, which fixes
symfony/symfony#37046,
removing the need for the workarounds introduced in
TypeHintedParamAwareInput.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

composer.json

@@ -29,7 +29,7 @@
         "php": "^7.3",
         "ocramius/package-versions": "^1.0",
         "psr/container": "^1.0",
-        "symfony/console": "^4.3 || ^5.0",
+        "symfony/console": "^4.3 || ^5.1.2",
         "symfony/event-dispatcher": "^4.0 || ^5.0",
         "symfony/polyfill-php80": "^1.17"
     },

src/Input/TypeHintedParamAwareInput.php

@@ -23,11 +23,7 @@ final class TypeHintedParamAwareInput extends AbstractParamAwareInput
 {
     protected function modifyQuestion(Question $question): void
     {
-        // @todo Remove once https://github.com/symfony/symfony/issues/37046 is
-        //     addressed
-        if ($question->getMaxAttempts() === null) {
-            $question->setMaxAttempts(1000);
-        }
+        // deliberate no-op
     }
 
     // Proxy methods implementing interface