Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most variants of module.exports = { ... } fixable #17

Merged

Conversation

papandreou
Copy link

This is mysticatea#208 against your fork now that eslint-plugin-node is unmaintained and eslint-plugin-n is being used by eslint-config-standard 😇

It got reviewed by the original author, who then disappeared before merging it.

@aladdin-add aladdin-add self-requested a review April 24, 2022 09:13
@papandreou
Copy link
Author

CI failure (npm ERR! 409 Conflict - GET https://registry.npmjs.org/astral-regex ) seems unrelated as I'm not touching any dependencies: https://github.com/weiran-zsd/eslint-plugin-node/runs/6145701620?check_suite_focus=true#step:4:9 🤔

@aladdin-add
Copy link

no worries, I've re-run the ci - seems working now! 🎉

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor suggestions, thx for the contributing! ~

lib/rules/exports-style.js Outdated Show resolved Hide resolved
lib/rules/exports-style.js Outdated Show resolved Hide resolved
lib/rules/exports-style.js Outdated Show resolved Hide resolved
tests/lib/rules/exports-style.js Show resolved Hide resolved
papandreou added a commit to papandreou/eslint-plugin-node that referenced this pull request Apr 24, 2022
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 7e2bf41 into eslint-community:master Apr 25, 2022
@aladdin-add
Copy link

released in v15.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants